fix bug where directory target were not handled according to the specification#794
Closed
Martin Torp (mtorp) wants to merge 4 commits intomainfrom
Closed
fix bug where directory target were not handled according to the specification#794Martin Torp (mtorp) wants to merge 4 commits intomainfrom
Martin Torp (mtorp) wants to merge 4 commits intomainfrom
Conversation
Martin Torp (mtorp)
requested review from
John-David Dalton (jdalton) and
Peter van der Zee (pvdz)
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Oct 22, 2025
When a directory path is provided, it now recursively scans that directory for all files by appending /**/* to the path pattern. This ensures directory targets work as expected in scanning operations. Also fixes a type annotation issue in getWorkspaceGlobs. Cherry-picked from PR #794 (commit 5f78dfd) Original author: Martin Torp <martin@socket.dev> Co-Authored-By: Martin Torp <martin@socket.dev>
Contributor
|
Merging in manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running something like
socket scan create ./path/to/some/folder/with/manifestspreviously resulted in the error:But the help menu specification for target includes: If it is a dir, the dir is scanned for any supported manifest files. I've updated glob.mts such that it now behaves according to the specification.